Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hijack.sh: make late logger config changes to nudge stuck DMA traces #663

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Apr 23, 2021

There are bugs that cause DMA drops and the last few lines to get stuck
somewhere. Changing the logger configuration and waiting for 1 second
seems to be enough to nudge the system and force it to DMA a bit more
logs: hopefully all the logs relevant to the current test.

Running this logger configuration command twice makes it very easy to
observe the stuck lines bug: the "ipc" logs corresponding to this -F
command will appear only once at the end of the slogger.txt DMA trace!

Signed-off-by: Marc Herbert marc.herbert@intel.com

There are bugs that cause DMA drops and the last few lines to get stuck
somewhere. Changing the logger configuration and waiting for 1 second
seems to be enough to nudge the system and force it to DMA a bit more
logs: hopefully all the logs relevant to the current test.

Running this logger configuration command twice makes it very easy to
observe the stuck lines bug: the "ipc" logs corresponding to this -F
command will appear _only once_ at the end of the slogger.txt DMA trace!

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 23, 2021

https://sof-ci.01.org/softestpr/PR663/build673/devicetest failed on BYT because it has no "tone" component. The tests timed out because they aborted before printing PASS or FAIL. Both issues should be addressed on v2 just forced-pushed.

Some tests did not fail on BYT, most likely because they don't have set -e. See #312 about set -e.

Sampling a few other slogger outputs in build673 shows the desired effect is achieved.

@marc-hb marc-hb marked this pull request as ready for review April 23, 2021 07:36
@marc-hb marc-hb requested a review from a team as a code owner April 23, 2021 07:36
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 23, 2021

https://sof-ci.01.org/softestpr/PR663/build674/devicetest/ is all green. Looking at a few random slogger outputs shows that the logs are slightly incomplete as explained in the code comments.

@aiChaoSONG aiChaoSONG merged commit 89b0b24 into thesofproject:main Jun 7, 2021
@marc-hb marc-hb deleted the DMA-nudge branch June 12, 2021 04:00
@marc-hb marc-hb added the area:logs Log and results collection, storage, etc. label Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logs Log and results collection, storage, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants