Refine logger #1065
Refine logger #1065
Conversation
| dlogi '.ldc dictionary file not found, SOF logs collection disabled' | ||
| return 0 # 0 is 'true' | ||
| } | ||
| fi | ||
| fi | ||
|
|
||
| return 1 |
There was a problem hiding this comment.
An error condition should have a message stating what the error is before returning.
There was a problem hiding this comment.
Thanks @keqiaozhang ! This will pave way to enable SysT logging later on -> thesofproject/sof#7703
| dlogi 'IPC4 FW logging only support with SOF Zephyr build' | ||
| dlogi 'SOF logs collection is globally disabled.' | ||
| return 0 | ||
| else |
There was a problem hiding this comment.
+1. Less indentation and less nesting: easier to read.
case-lib/lib.sh
Outdated
| if [ ${OPT_VAL['s']} -eq 0 ]; then | ||
| return 0 | ||
| fi | ||
| [ ${OPT_VAL['s']} -eq 0 ] && return 0 |
There was a problem hiding this comment.
This is not needed and it looks incompatible with set -e. It's actually compatible with set -e but that's confusing.
It's also less readable for some people and distracting git churn in a too complex and too messy area of the code.
|
Please re-add check-sof-logger in some PR testing before merging this? Depending on recent daily test results. We used to have frequent failures but we're probably not testing these configurations. In any case it should run at least for MTL. |
|
https://sof-ci.01.org/softestpr/PR1065/build474/devicetest/index.html and https://sof-ci.01.org/softestpr/PR1065/build474/devicetest/index.html are all green (but 10 days old now) https://sof-ci.01.org/softestpr/PR1065/build475/devicetest/index.html is mostly There's also been other changes merged. Re-running. |
|
SOFCI TEST EDIT: good results in https://sof-ci.01.org/softestpr/PR1065/build543/devicetest/index.html, https://sof-ci.01.org/softestpr/PR1065/build542/devicetest/index.html and https://sof-ci.01.org/softestpr/PR1065/build544/devicetest/index.html, only suspend/resume failures + known thesofproject/sof#7759 |
On IPC4 platforms, we only check logger with Zephyr build firmware and no need to check the ldc file. The ldc file checking only when testing with IPC3 firmware. Signed-off-by: Keqiao Zhang <keqiao.zhang@intel.com>
No need to check the ldc file on IPC4 Zephyr platforms and swith to use firmware file to determine whether it is a Zephyr build FW. Signed-off-by: Keqiao Zhang <keqiao.zhang@intel.com>
Before we used cavstool.py as a temporary solution on IPC3 Zephyr platforms for etrace, but now IPC3 Zephyr built FW is no longer supported. Signed-off-by: Keqiao Zhang <keqiao.zhang@intel.com>
keqiaozhang
force-pushed
the
refine_logger
branch
from
27494d1
to
7960aef
Compare
|
Updated, sof-logger check passed and no side-effects. |
No description provided.