[DO NOT MERGE] ASoC: SOF: Intel: lnl: partial clock gating disable #5151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the IPC timeout for LNL platforms as larger timeouts have been observed when IPCs are sent during system suspend process.
Test patch to disable clock gating.
plbossart
reviewed
Aug 22, 2024
| @@ -47,6 +47,7 @@ static const struct sof_dev_desc lnl_desc = { | |||
| .nocodec_tplg_filename = "sof-lnl-nocodec.tplg", | |||
| .ops = &sof_lnl_ops, | |||
| .ops_init = sof_lnl_ops_init, | |||
| .ipc_timeout = 5000, | |||
There was a problem hiding this comment.
the default is 500ms, that seems plenty for an IPC, no? Moving to a 5s timeout to deal with a suspend-resume problem means suspend-resume is already broken in the first place, regardless of the IPCs...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.