Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr5042 mod #5047

Closed
wants to merge 14 commits into from
Closed

Commits on Jun 6, 2024

  1. [HACK] soundwire: stream: add traces to figure out bank switch issues

    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    plbossart authored and bardliao committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    71a7724 View commit details
    Browse the repository at this point in the history
  2. soundwire: bus: add traces to see if the first read is blocked

    Testing the theory that if the interrupt happens during a bank switch
    the first read will be blocked and since the interrupts are now
    disabled the bank switch will fail as well.
    
    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    plbossart authored and bardliao committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    22f1d7a View commit details
    Browse the repository at this point in the history
  3. HACK: soundwire: add trace to check msg transfer

    Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
    bardliao committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    b167bbc View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. [HACK]: ASoC: SOF: LNL: add trace to check sdw irq enable/disable

    Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
    bardliao committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    d2ab3e1 View commit details
    Browse the repository at this point in the history
  2. soundwire: intel_ace2x: add more traces around sync_arm/sync_go

    We want to make sure the sync_go does happen after the last write
    
    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    plbossart committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    d3085ee View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. soundwire: cadence: add soft-reset on startup

    Follow the recommended programming flows.
    
    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    plbossart committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    f790d22 View commit details
    Browse the repository at this point in the history
  2. soundwire: cadence: enable interrupts after the clock restarts

    For some reason, we don't have a symmetry between clock stop and clock
    start. We should disable the interrupts first on clock stop, and
    re-enable them last on clock restart.
    
    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    plbossart committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    6dd4bff View commit details
    Browse the repository at this point in the history
  3. soundwire: cadence: clear MCP BLOCK_WAKEUP in init

    Follow recommended programming flows.
    
    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    plbossart committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    f80718e View commit details
    Browse the repository at this point in the history
  4. soundwire: add delay after sync_go

    Test hypothesis that a delay might help with rate conditions
    
    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    plbossart committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    0445088 View commit details
    Browse the repository at this point in the history
  5. soundwire: stream: clarify error log on bank switch timeout

    Add the controller and link id to better identify the failure.
    
    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    plbossart committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    27ab214 View commit details
    Browse the repository at this point in the history
  6. soundwire: bus: add more traces on sdw_transfer

    The exclusion between regular and deferred messages doesn't seem quite
    right.
    
    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    plbossart committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    d0d0146 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. soundwire: intel_ace2x: add dynamic debug logs for AC timing registers

    These registers come straight from platform firmware properties, for
    integration/debug it's useful to know the values directly from the
    kernel logs.
    
    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    plbossart committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    065df57 View commit details
    Browse the repository at this point in the history
  2. soundwire: cadence: export cdns_enable_slave_alerts

    We need a helper to disable peripheral alerts during bank switchs.
    
    FIXME: cancelling the work locks the system, something is still off
    
    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    plbossart committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    e5e7bff View commit details
    Browse the repository at this point in the history
  3. soundwire: intel_bus_common: prevent peripheral interrupts during bus…

    … config
    
    There is an potential deadlock on Intel platforms with the following
    scenario:
    
    a) the bank switch starts and the msg->lock is taken
    
    b) an interrupt happens and the workqueue schedules a read from
    IntStat0 register, which is blocked by the msg->lock
    
    c) the manager writes the bank switch command, which is blocked by the
    read that won't go out.
    
    b) is blocked by a) and c) is blocked by b).
    
    This patch suggests disabling the peripheral interrupts temporarily
    during sync_arm/sync_go sequences used by the bank switch.
    
    FIXME: What happens if there's already a work scheduled?
    
    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    plbossart committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    055ed87 View commit details
    Browse the repository at this point in the history