[HACK] soundwire: add traces to debug bank switch issues #5042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is stuck for over 3 hours now. I can't even see it in the internal build results as having started or failed. |
|
SOFCI TEST |
plbossart
reviewed
Jun 6, 2024
plbossart
reviewed
Jun 6, 2024
bardliao
force-pushed
the
debug-bank-switch-error
branch
from
b20e0f1
to
6aa76f5
Compare
|
SOFCI TEST |
Still can't get the reason of "Controller Timed out on bank switch". Just didn't get the CDNS_MCP_INT_RX_WL irq. |
bardliao
force-pushed
the
debug-bank-switch-error
branch
from
6aa76f5
to
b167bbc
Compare
|
well this is progress in my book @bardliao. At least we know it's not the jack interrupt, it's not a race condition between bank switch and other writes, it's squarely a missed interrupt issue. Do you mind adding a log when we disable the SoundWire interrupts? I don't think it's the reason, because we had multiple transfers active before the bank switch, but it'd prove that the interrupts are on. |
|
SOFCI TEST |
2 similar comments
|
SOFCI TEST |
|
SOFCI TEST |
|
Something's not right in the results, I can't see the traces in the logs. |
|
SOFCI TEST |
Closed
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Testing the theory that if the interrupt happens during a bank switch the first read will be blocked and since the interrupts are now disabled the bank switch will fail as well. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
We want to make sure the sync_go does happen after the last write Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Follow the recommended programming flows. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
For some reason, we don't have a symmetry between clock stop and clock start. We should disable the interrupts first on clock stop, and re-enable them last on clock restart. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Follow recommended programming flows. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Test hypothesis that a delay might help with rate conditions Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
The exclusion between regular and deferred messages doesn't seem quite right. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
These registers come straight from platform firmware properties, for integration/debug it's useful to know the values directly from the kernel logs. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
debug-bank-switch-error
branch
from
d2ab3e1
to
0e7211a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.