Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SoC: intel: sof_sdw: Add support for product Ripto #2357

Merged
merged 1 commit into from
Aug 13, 2020
Merged

SoC: intel: sof_sdw: Add support for product Ripto #2357

merged 1 commit into from
Aug 13, 2020

Conversation

RanderWang
Copy link

@RanderWang RanderWang commented Aug 12, 2020 •
edited
Loading

Ripto is another product based on TGL with the same
audio hardware configuration as Volteer.

plbossart
plbossart requested changes Aug 12, 2020
View reviewed changes
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message typo.

@RanderWang
SoC: intel: sof_sdw: Add support for product Ripto
d78c512 
Ripto is another product based on TGL with the same
audio hardware configuration as Volteer.

Signed-off-by: Rander Wang <rander.wang@intel.com>
@RanderWang
Copy link
Author

update this PR, thanks!

@plbossart
Copy link
Member

Not sure what's going on with CI but now we have failures on Up2 nocodec. Gah, this is painful that instabilities keep coming randomly. This PR has NOTHING to do with Up2 nocodec.
@xiulipan @fredoh9 @marc-hb @lyakh @lgirdwood FYI.

@xiulipan
Copy link

@plbossart This issue worth debug, it seems we have some issue with our test case error handling. The case did not show any error, but some background log collection error happen.

@marc-hb
Copy link
Collaborator

marc-hb commented Aug 13, 2020

but now we have failures on Up2 nocodec.

We started paying more attention to the sof-logger (and there's more coming, see thesofproject/sof-test#297 and 298)

The two failures in https://sof-ci.01.org/linuxpr/PR2357/build4293/devicetest/ look basically the same:

2020-08-13 01:58:18 UTC [REMOTE_ERROR] sof-logger was already dead  # (new test)

At the bottom of the (long) slogger tab:

error: Invalid filename length or ldc file does not match firmware

@keyonjie
Copy link

SOFCI TEST

@RanderWang
Copy link
Author

This PR only enable sdw support in sdw machine driver, thereby it doesn't lead to APL failed.

@bardliao bardliao merged commit c7a3969 into thesofproject:topic/sof-dev Aug 13, 2020
@marc-hb marc-hb mentioned this pull request Aug 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbossart plbossart plbossart approved these changes

@bardliao bardliao bardliao approved these changes

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

@kv2019i kv2019i Awaiting requested review from kv2019i kv2019i is a code owner

@lgirdwood lgirdwood Awaiting requested review from lgirdwood lgirdwood is a code owner

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RanderWang @plbossart @xiulipan @marc-hb @keyonjie @bardliao