fix: set inner.pinned_cpu for pinned tasks
#1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When spawning a pinned task, `spawn` didn't previously set `inner.pinned_cpu`. This created problems in theseus-os#1042 because the scheduler didn't know that tasks were pinned and freely migrated them across cores. Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
github-actions bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
* When spawning a pinned task, `spawn` didn't previously set `inner.pinned_cpu` for the newly-created `Task`. * This is not currently a problem because the scheduler doesn't perform task migration across CPUs, but when that gets enabled (in #1042), it would cause the pinning choice to be ignore by the scheduler. Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com> cae8ca8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When spawning a pinned task,
spawndidn't previously setinner.pinned_cpu. This created problems in #1042 because the scheduler didn't know that tasks were pinned and freely migrated them across cores.