Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circle config #1

Closed
wants to merge 9 commits into from
Closed

circle config #1

wants to merge 9 commits into from

Conversation

thescientist13
Copy link
Owner

@thescientist13 thescientist13 commented Mar 28, 2018

testing nodejs configurations with CircleCI

current issues

  1. can't figure out why the test failures aren't consistent (not failing locally on OSX)
  2. test failures doesn't cause the build to fail

@thescientist13
Copy link
Owner Author

thescientist13 commented Mar 28, 2018

One thing I noticed while debugging locally on master was that it looks like mocha is swallowing exceptions, not sure if that is an issue or not
mochajs/mocha#2797

which might explains why I couldn't find the issue of the CSS comment "breaking" the build so evidently before.

    records:
      { 'html-webpack-plugin for "index.html"': [Array],
        'extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js!test/cases/generate-critical-css/index.css': [Array],
        'extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js!test/cases/generate-critical-css/main.css': [Array],
        modules: [Object],
        nextFreeChunkId: undefined,
        chunks: [Object] },
     nextFreeModuleIndex: 5,
     nextFreeModuleIndex2: 5,
     additionalChunkAssets: [],
     assets:
      { 'main.js': [Object],
        'index.js': [Object],
        'styles.da22eda767cd98613b04.css': [Object],
        'index.html': [Object] },
     errors:
      [ ModuleBuildError: Module build failed: ModuleBuildError: Module build failed: Unknown word (14:38)

  12 | .fade-appear.fade-appear-active {
  13 |   opacity: 1;
> 14 |   transition: opacity 600ms ease-in; //ms should match the value of transitionAppearTimeout
     |                                      ^
  15 | }


...

      ✓ should generate the expected critical inline <style> tag (1312ms)
      ✓ should generate the expected critical <link> tag (931ms)
      ✓ should generate the expected critical <noscript> tag (1011ms)

  HtmlCriticalWebpackPlugin
    webpack hooks
      ✓ HtmlCriticalWebpackPlugin has the required apply method
      ✓ HtmlCriticalWebpackPlugin has the required emit method


  5 passing (3s)

Anyway , as for the current issue here, based on the build logs, it looks like it has something to do with mocha / timeouts / exception swallowing warnings.

I might also give ava a chance, which I've had some luck with for testing webpack plugins before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant