Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed WETH9.sol solidity version and ETH transfer #5

Closed
wants to merge 1 commit into from

Conversation

da-bao-jian
Copy link

When importing WETH9.sol from other contracts, it won't compile due to inconsistent Solidity versions. All the other challenge contracts use v0.8 yet WETH9 uses v0.7. I upgraded WETH9 to v0.8.0 and made the corresponding changes to make sure it compiles.

jonatascm added a commit to jonatascm/damn-vulnerable-defi that referenced this pull request Feb 20, 2022
zhongeric added a commit to zhongeric/damn-vulnerable-defi that referenced this pull request Mar 19, 2022
redace85 added a commit to redace85/damn-vulnerable-defi that referenced this pull request Jun 16, 2022
redace85 added a commit to redace85/damn-vulnerable-defi that referenced this pull request Jul 7, 2022
redace85 added a commit to redace85/damn-vulnerable-defi that referenced this pull request Jul 7, 2022
zzzuhaibmohd added a commit to zzzuhaibmohd/damn-vulnerable-defi-solutions that referenced this pull request Jul 15, 2022
zzzuhaibmohd added a commit to zzzuhaibmohd/damn-vulnerable-defi-solutions that referenced this pull request Jul 15, 2022
JonathanAmenechi added a commit to JonathanAmenechi/damn-vulnerable-defi that referenced this pull request Aug 27, 2022
JonathanAmenechi added a commit to JonathanAmenechi/damn-vulnerable-defi that referenced this pull request Aug 27, 2022
chienpao pushed a commit to chienpao/damn-vulnerable-defi that referenced this pull request Nov 27, 2022
@tinchoabbate
Copy link
Collaborator

Thanks! Following your suggestion, v3 now uses WETH in 0.8, straight from Solmate.

marchev pushed a commit to marchev/damn-vulnerable-defi that referenced this pull request May 26, 2023
marchev pushed a commit to marchev/damn-vulnerable-defi that referenced this pull request May 26, 2023
jasonjgarcia24 pushed a commit to jasonjgarcia24/damn-vulnerable-defi that referenced this pull request Jun 22, 2023
- In Solidity code, buyOne now returns the token ID
- In Javascript code, removed unused variable and added additional requirement in post-condition for the challenge
pkqs90 added a commit to pkqs90/damn-vulnerable-defi that referenced this pull request Dec 11, 2023
kaxxa123 added a commit to kaxxa123/damn-vulnerable-defi that referenced this pull request Feb 22, 2024
alekoisaev added a commit to alekoisaev/damn-vulnerable-defi that referenced this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants