Allow CryptTrait to accept a \Defuse\Crypto\Key as encryption key #812

[SunMar]

See #812 for details. This allows a Key object to be used as encryption key over an alphanumeric string which improves performance of encryption and decryption.

[Sephster]

Looks good to me. The only thing I spotted was that we should update the docblocks for the setEncryptionKey functions in GrantTypeInterface and ResponseTypeInterface. I think once this change is made this will be good to merge in unless anyone has any objections. Thanks for creating the PR

[SunMar]

@Sephster Ah yes, sorry, forgot about those interfaces. Phpdoc updated for the interfaces too.

[SunMar]

I also updated the PR to remove some code duplication in the CryptTraitTest.

[simonhamp]

Looks fine to me.

Is it possible for the if statements in CrypTrait to be factored out by following the example set in the tests? I.e by using setEncryptionKey And doEncrypt/doDecrypt methods instead of encrypt/decrypt/WithPassword.

[SunMar]

@simonhamp setEncryptionKey() is called by AuthorizationServer and is basically a pass-through for whatever encryption key is passed when doing a new AuthorizationServer, which is done by whoever is implementing this package and is not done by the package itself.

So I'm not really sure how to get rid of the if, because the library doesn't have control over whether the encryption is a string or a Key. This way it stays backwards compatible, if you pass a string it does the current implementation of encryptWithPassword() and only if you pass a Key it uses encrypt().

Note that in the tests doEncrypt() and doDecrypt() are just pass-throughs in the stub to encrypt() and decrypt() because they are protected and can't be called directly. See CryptTraitStub.

[simonhamp]

That’s fine. Nice clean PR good to go from my POV

[SunMar]

@Sephster Is the PR ok for you too? I updated the change you requested.

[Sephster]

Sorry for the delay in getting this reviewed @SunMar. I've made some minor changes but all looks good so merging in. Thanks for your patience and your contribution