[RFC] Move doctrine packages to suggest section #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it a use case of yours? I think I prefer to be pragmatic and not complicate the setup unless someone actually complains about it |
|
I added the bundle to a small app without any doctrine package, which got me wondering if we should make this change before 1.0, but I'm OK with your pragmatic point of view |
|
Thinking twice about it, the 98% use case probably installs the ORM first so I'm fine with this. |
chalasr
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can move doctrine packages to suggest section.
What do you think? Should we edit the bundle recipe to use
in_memoryas persistence layer?