Remove deprecated Guzzle function call #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `GuzzleHttp\Psr7\uri_for` function is deprecated and removed in Guzzle 7.2. Where available `GuzzleHttp\Psr7\Utils::uriFor` is used instead. Given we support Guzzle 6 and 7, both the method and function call are required to be supported. Fixes #134.
bencorlett
force-pushed
the
fix/guzzle-functions
branch
from
7401034 to
03c502c
Compare
|
Hi, I have this issue yesterday and tested this PR. Seems to be a good solution. |
|
Have the same issue, tested this PR and it solves the problem as well |
This is not true. Guzzle follows semantic versioning. |
|
See #136. :) |
|
@GrahamCampbell if you would like, feel welcome to submit a PR |
bencorlett
added a commit
that referenced
this pull request
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GuzzleHttp\Psr7\uri_forfunction is deprecated and removed in Guzzle 7.2. Where availableGuzzleHttp\Psr7\Utils::uriForis used instead.Given we support Guzzle 6 and 7, both the method and function call are required to be supported.
Fixes #134.