Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more export-ignore to slim down composer package. #50

Merged
merged 1 commit into from
Sep 1, 2015
Merged

Add more export-ignore to slim down composer package. #50

merged 1 commit into from
Sep 1, 2015

Conversation

jdufresne
Copy link
Contributor

No description provided.

@colinodell
Copy link
Member

I'd like to keep the README, and probably demo too. If you could remove
those lines I'll go ahead and accept this.

Thanks!

On Mon, Aug 31, 2015, 10:17 PM Jon Dufresne notifications@github.com
wrote:


You can view, comment on, or merge this pull request online at:

#50
Commit Summary

  • Add more export-ignore to slim down composer package.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#50.

@jdufresne
Copy link
Contributor Author

I'd like to keep the README, and probably demo too. If you could remove those lines I'll go ahead and accept this.

Done.

However, I ask that you reconsider the demo directory.

Keep in mind that many people use composer to download dependencies for production sites. Downloading third party documentation and examples is time consuming and goes to waste on these sites. The demo is still available to those who want it, but not forced on people during production deployment. As more and more 3rd party packages include examples, documentation and tests, the extra time spent during deployment of these sites really adds up.

@colinodell
Copy link
Member

You make some really good points. I definitely want to keep the README, as it's a single file with everything you'd need to know.

The more I think about it, the more I feel we can probably maybe remove the demo altogether since only a handful of users would find it useful, compared the README which is useful for everyone. Would you like to submit a PR for it's deletion? We'll keep it open for a few days in case there are objections and then hopefully accept it :)

colinodell added a commit that referenced this pull request Sep 1, 2015
Add more export-ignore to slim down composer package.
@colinodell colinodell merged commit e2f06a9 into thephpleague:master Sep 1, 2015
colinodell added a commit that referenced this pull request Sep 1, 2015
@jdufresne
Copy link
Contributor Author

Would you like to submit a PR for it's deletion? We'll keep it open for a few days in case there are objections and then hopefully accept it :)

Will do. Thanks.

@jdufresne jdufresne mentioned this pull request Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants