Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consecutive emphasis producing incorrect markdown #202

Merged
merged 2 commits into from
Mar 28, 2021

Conversation

markopy
Copy link
Contributor

@markopy markopy commented Mar 28, 2021

This is a fix for issue #199.

By checking the type of the immediate previous or following sibling node we can avoid emitting the incorrect style. To access the previous sibling we need to cache it on Element creation because it will already be replaced by markdown when the current node is being converted.

@colinodell colinodell merged commit 489c7c0 into thephpleague:master Mar 28, 2021
@colinodell
Copy link
Member

Thank you! 🐬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants