[develop] Serializers

[jasonlewis]

Same as #45 except now targeting the develop branch.

Got some rogue commits. Not sure why. 😦

[jasonlewis]

Okay fixed rogue commits. You may want to look over it again and make sure everything is where it should be (gotta love Git sometimes). 😁

[philsturgeon]

This should fail. If it doesnt then its a merge problem. Transformers no longer have direct access to the manager, as they do that via the "setCurrentScope()" method, which then has access to the manager. Scopes have manager passed in their constructor, so this seemed like a reasonably useful way to cut down dependencies.

[philsturgeon]

Like this https://github.com/thephpleague/fractal/pull/47/files#diff-d62ca98eb6369f4cfaa659c35f10c294R67

[jasonlewis]

Good pick up, flying under the radar since it's throwing a BadMethodCallException as well. Bloody thing.

[philsturgeon]

This looks perfect so far. I’m gonna play locally with some sample code instead of just relying on unit tests.

TDD is great and all BUT ITS SCARY AND I DONT TRUST IT.
-- 
Phil Sturgeon

On May 11, 2014 at 11:55:27 AM, Jason Lewis (notifications@github.com) wrote:

In tests/TransformerAbstractTest.php:

@@ -102,7 +102,8 @@ public function testProcessEmbeddedResourcesInvalidAvailableEmbed()
$manager = new Manager;
$manager->parseIncludes('book');

•    $scope = new Scope($manager, m::mock('League\Fractal\Resource\ResourceInterface'));
  

•    $scope = new Scope($manager, m::mock('League\Fractal\Resource\ResourceAbstract'));
  

•    $transformer->setManager($manager);
  

  Good pick up, flying under the radar since it's throwing a BadMethodCallException as well. Bloody thing.

—
Reply to this email directly or view it on GitHub.

[jasonlewis]

Okay all fixed, hopefully. Regarding you outdated diff comment: no worries. I think I'll add a basic HAL serializer soon and push that up.

Also there's no meta yet even though the Collection resource references some. So will add that in as well.

[philsturgeon]

This is now merged to develop, but does have an outstanding issue relating to allow Serializers to sideload or embed their relationships. Add that as a new PR and we'll be good to go.