Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version: 1.1.0 #1183

Merged
merged 22 commits into from
Aug 9, 2020
Merged

Version: 1.1.0 #1183

merged 22 commits into from
Aug 9, 2020

Conversation

frankdejonge
Copy link
Member

No description provided.

GrahamCampbell
GrahamCampbell suggested changes Aug 8, 2020
View reviewed changes
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments. :)

composer.json Outdated Show resolved Hide resolved
tests/ForcedCopyPluginTests.php Outdated Show resolved Hide resolved
tests/FtpTests.php Outdated Show resolved Hide resolved
tests/FtpTests.php Show resolved Hide resolved
@frankdejonge
Copy link
Member Author

@GrahamCampbell thanks for the review 👍 much appreciated. I've pushed changed to handle them.

@frankdejonge frankdejonge mentioned this pull request Aug 9, 2020
Closed
GrahamCampbell
GrahamCampbell suggested changes Aug 9, 2020
View reviewed changes
composer.json Show resolved Hide resolved
@driesvints driesvints mentioned this pull request Aug 9, 2020
Merged
17 tasks
GrahamCampbell
GrahamCampbell approved these changes Aug 9, 2020
View reviewed changes
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@frankdejonge
Upgrade PHPUnit and PHPSpec
e93e310
@frankdejonge
Fixated prophecy in composer.json
87d3df1
@frankdejonge
Require league/mime-type-detection
7e5a9d7
@frankdejonge
Remove finfo existence checks, it's a required dependency.
4e9ad8f
@frankdejonge
Use the league/mime-type-detection component
96f9914
@frankdejonge
Change visibility, remove unused imports.
0db89bd
@frankdejonge
Augment previous behavior
e819698
@frankdejonge
Corrected mime-type, I'm an idiot.
c92a919
@frankdejonge
Use methods insetad of annotations for exception assertions
2b43bd4
@frankdejonge
Skip test on PHP 8
bc5d6b2
@frankdejonge
Remove specs.
b21de01
@frankdejonge
Mark as not expecting assertions
9bcb54a
@frankdejonge
Remove CS fixing
94de78e
@frankdejonge
Remove useless travis instruction
9114c1d
@frankdejonge
Different php version check.
d454cbb
@frankdejonge
Re-implement test to try to prevent an error
f534c23
@frankdejonge
Change visibility
a684a3a
@frankdejonge
Remove PHPUnitHacks.
d073ab1
@frankdejonge
Remove redundant assertion
e9e234a
@frankdejonge
Adjust version check
e34eb96
@frankdejonge
Adjust PHP version constraint
1288724
@frankdejonge frankdejonge merged commit 481c017 into 1.x Aug 9, 2020
@frankdejonge frankdejonge deleted the version/1.1.0 branch August 9, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankdejonge @GrahamCampbell