Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get all defined definitions #435

Merged
merged 3 commits into from
Oct 18, 2016

Conversation

ls-michielrensen
Copy link
Contributor

This PR adds a small convenience method in order to get all defined model definitions.
This is especially useful if you want to load different sets of factories based on the context.

@GrahamCampbell
Copy link
Member

Are you getting them in order to mutate them? If so, I don't think this would be a good practice.

@ls-michielrensen
Copy link
Contributor Author

No, I'm getting them in order to create them, I use it as a sort of seeder if you will.

@GrahamCampbell GrahamCampbell merged commit a8d6a64 into thephpleague:master Oct 18, 2016
@GrahamCampbell
Copy link
Member

Ok, thanks for the PR. :)

@ls-michielrensen
Copy link
Contributor Author

@GrahamCampbell as it adds a public method, I guess an update to the docs is needed as well? Do you know in what release this PR will be?

@ls-michielrensen ls-michielrensen deleted the patch-1 branch November 10, 2016 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants