Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Improvements #313

Merged
merged 1 commit into from
Sep 2, 2014
Merged

Testing Improvements #313

merged 1 commit into from
Sep 2, 2014

Conversation

GrahamCampbell
Copy link
Member

Let's remove the deprecated --dev flag from the composer install and improve the phpunit config.

@GrahamCampbell GrahamCampbell added this to the v2.1.1 milestone Sep 2, 2014
</testsuite>
</testsuites>
<filter>
<whitelist addUncoveredFilesFromWhitelist="true">
<whitelist processUncoveredFilesFromWhitelist="true">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just playing around with this on a project. What's the diff between process and add?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add is the legacy version of the command. Basically, the process command is slightly better because it runs a few more checks before including the file, but add was retained for backwards compatibility.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea what version it was added in?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either 3.7, or 4.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just checked the docs and it was added in 3.7.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah just check too. thanks. 👍

GrahamCampbell added a commit that referenced this pull request Sep 2, 2014
@GrahamCampbell GrahamCampbell merged commit 64ae006 into thephpleague:2.1 Sep 2, 2014
@GrahamCampbell GrahamCampbell deleted the 2.1-tests branch September 2, 2014 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants