-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the escalation service to use group contracts #63
Conversation
Signed-off-by: Reece Dunham <me@rdil.rocks>
What's left to be done with this? |
Waiting for Kaki to get all the latest escalation group definitions and level definitions from official. |
Most escalations are done, our custom escalations still don't have group definitions. |
Added localization and missing groupdefinitions for Peacock custom escalations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little snag, but other than that LGTM. Not checked any of the contracts we've added/moved as from experience in playing a few, they're all good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The escalation level picker needs to be fixed/updated afterwards. Doesn't have to be part of this PR though.
Also we need to make sure whether we want to include legacy escalations or not. Theoretically they should always be included in H1, but not in H2/H3. Therefore I think we can include them in the code but only show them for H1, and toggle their appearance on H2/H3 with a flag. Choosing to do this will also remove the need for the legacy escalations plugin. |
Just fixed the escalation level picker. Was a simple fix as I just had to change how it accessed the escalation mappings and got the level count. RE: Legacy Escalations EDIT: In addition to this, including them into core Peacock will increase the file size, and then hiding them behind a flag just seems pointless as people may never play 2016 or enable them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes just to stop merging before Escalation Codenames has been updated with all the new H3 escalations we've added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the new H3 escalations to Escalation Codenames. Should be good to go now.
EDIT: Also fixed some issues with escalation completion. What we're going to do with Legacy Escalations still needs to be decided.
I agree that they can be added to all game versions. |
What I just pushed makes the hits category for elusives respect the new Season tag, this now removes The Deceivers from the page when playing in Hitman 2016. |
Now squashed!