Remove variance branch length parameter #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter muddies the waters. It was originally added to scale the prior distribution for the branch lengths, and initially (wrongly) played quite a significant role in assignment. We realised that this didn't make sense, and decided to either relax it or to remove it (#13). At that time we did some tuning experiments, comparing to TreeTime results, and found that a value of 10 performed a tiny fraction better than a value of 100 (but probably within random noise). At that time I decided to relax it to 10 rather than remove it entirely, based on that data. But upon receiving reviews for the paper I have decided to remove it both because
I have just some testing and shown that for the sort of datasets we're interested in it really makes almost no difference, and I'm sure in some cases things will work better without it.