Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orion broken on arm64e iOS 14 due to Xcode 11 being used. #4

Closed
Absolucy opened this issue Mar 8, 2021 · 4 comments
Closed

Orion broken on arm64e iOS 14 due to Xcode 11 being used. #4

Absolucy opened this issue Mar 8, 2021 · 4 comments
Labels
high priority This is high priority

Comments

@Absolucy
Copy link

Absolucy commented Mar 8, 2021

Orion.framework is compiled with Xcode 11.
Xcode 11 swift apps break on arm64e iOS 14.

Orion tweaks crash in orion_init on arm64e iOS 14:

Call stack:
--
2 | 0   ColoredSwipe.dylib                0x0000000101132e00 0x10112c000 + 28160          // orion_init()
3 | 1   ColoredSwipe.dylib                0x0000000101132ddc 0x10112c000 + 28124          // orion_init()
4 | 2   ColoredSwipe.dylib                0x0000000101132da0 0x10112c000 + 28064          // orion_init
5 | 3   ColoredSwipe.dylib                0x0000000101132828 0x10112c000 + 26664          // init
@Absolucy Absolucy changed the title Orion broken on arm64e iOS 14 Orion broken on arm64e iOS 14 due to Xcode 11 being used. Mar 8, 2021
@kabiroberai kabiroberai added the high priority This is high priority label Mar 8, 2021
@kabiroberai
Copy link
Member

To elaborate on this, the issue here is that Orion itself is built with Xcode 11 (i.e. the iOS 13 arm64e ABI). We can probably fix this by creating sub-packages and making org.theos.orion itself depend on firmware (< 14.0) | org.theos.orion-14, firmware (>= 14.0) | org.theos.orion-13

@Absolucy
Copy link
Author

Absolucy commented Mar 8, 2021

@kabiroberai couldn't that just be done with 2 packages and provides?

kabiroberai added a commit that referenced this issue Mar 14, 2021
Tentative solution for #4 (credit for suggestion to use `Provides` goes to @aspenluxxxy)
@kabiroberai
Copy link
Member

b40a048 should hopefully fix this but we'll only be able to find out when I tag the next release (and the gh action runs), so fingers crossed 🙃

@kabiroberai
Copy link
Member

Closing to keep things tidy; if this is still broken once 0.9.2 is released, please reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority This is high priority
Projects
None yet
Development

No branches or pull requests

2 participants