Add SelectLocated, golangci-lint, NormalizedPath #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 14 15 +1
Lines 1732 1873 +141
==========================================
+ Hits 1732 1873 +141 ☔ View full report in Codecov by Sentry. |
`SelectLocated` works just like `Select`, but returns a slice of `LocatedNode`s that contain the same nodes as those returned by `Select` paired with `NormalizedPath`s that uniquely identify their locations within the JSON query argument. [RFC 9535 section 2.7] defines normalized paths, including their string representation, implemented here. The design largely borrows from [serde_json_path]'s [`query_located`] method. Add `SelectLocated` to the `Selector` interface and implement it in each selector, segments, and queries. The implementation is quite similar to `Select`, but takes care to properly construct `NormalizedPath`s for each selected node. Update all tests to validate both methods. The new `NormalSelector` interface defines normalized path selectors, of which there are two: `Index` and `Name`. `Name`, in particular, attempts to hew to the RFC's stringification grammar as closely as possible. Also: upgrade golangci-lint to v1.62.2 and update its configuration [RFC 9535 section 2.7]: https://www.rfc-editor.org/rfc/rfc9535#section-2.7 [serde_json_path]: https://github.com/hiltontj/serde_json_path [`query_located`]: https://docs.rs/serde_json_path/latest/serde_json_path/struct.JsonPath.html#method.query_located
And record the the addition of `SelectLocated` in the change log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SelectLocatedworks just likeSelect, but returns a slice ofLocatedNodes that contain the same nodes as those returned bySelectpaired withNormalizedPaths that uniquely identify their locations within the JSON query argument. RFC 9535 section 2.7 defines normalized paths, including their string representation, implemented here. The design largely borrows from serde_json_path'squery_locatedmethod.Add
SelectLocatedto theSelectorinterface and implement it in each selector, segments, and queries. The implementation is quite similar toSelect, but takes care to properly constructNormalizedPaths for each selected node. Update all tests to validate both methods.The new
NormalSelectorinterface defines normalized path selectors, of which there are two:IndexandName.Name, in particular, attempts to hew to the RFC's stringification grammar as closely as possible.Also: upgrade golangci-lint to v1.62.2 and update its configuration