fix: Feedback table alignment #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
approved these changes
Dec 18, 2024
| @@ -167,7 +167,7 @@ export const CollapsibleRow: React.FC<CollapsibleRowProps> = (item) => { | |||
| </TableCell> | |||
| </TableRow> | |||
| <TableRow sx={{ background: (theme) => theme.palette.background.paper }}> | |||
| <TableCell sx={{ padding: 0, border: "none" }} colSpan={4}> | |||
| <TableCell sx={{ padding: 0, border: "none" }} colSpan={5}> | |||
There was a problem hiding this comment.
One to think about when we're revising these tables - ideally this would dynamically reflect the number of columns.
There was a problem hiding this comment.
Agreed, there used to be a useful colspan="0" property that would span all available cells, which turned out to be a hack and was depreciated with HTML5. Other option is set an unrealistically high number (i.e. colspan="9999"), but that doesn't feel like a proper solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Quick one: fixes alignment of the feedback table dropdown, as another header row has been added.
Before:
After:
