feat: Add E2E Coverage for Property Information #4025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RODO94
force-pushed
the
rory/e2e-prop-info
branch
from
4c64c12 to
56ff48b
Compare
|
Removed vultr server and associated DNS entries |
add geoJson mock and types lint fix
RODO94
force-pushed
the
rory/e2e-prop-info
branch
from
56ff48b to
a6e5ccf
Compare
lint:fix remove unused import
RODO94
force-pushed
the
rory/e2e-prop-info
branch
from
2b589dd to
110a373
Compare
RODO94
commented
Dec 3, 2024
jessicamcinchak
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
One lingering comment but otherwise happy for this one to merge - thanks for adjusting per feedback!
Going forwards, would love to understand what would have helped make the expected steps of this test (eg how "change property type" works) more discoverable for you upfront without me catching that "Unknown" on first review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added coverage for the Property Information component in the E2E ui-driven tests.
Covered adding the component in the Editor, Navigating it in the Public view, and changing the property type.
In order to see if the map is working, I have added a check to review the
geoJsonDataattribute and ensure correct data is being added here, which should indicate the map is working.Added a new package here to bring in the same types as we use in the Editor for
Featureso we can match it up with the mock