refactor: Team component folder structure #3492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've split this into a separate PR from the ticket work I'm doing so that this can easily be discarded if it's rocking the boat too much / destroying a convention in the codebase!
But...I've basically massively shortened the length of
TeamMembers.tsx
by splitting out the two components that were defined in there intoMembersTable
andTeamMembers
, and also moving type definitions and styling declarations into their own files.In my opinion, this makes the component files a lot cleaner, easier to read and easier to work with! I just hate scrolling past loads of styling to find out what a component does 😅 And I thought I'd kind of start with this before I dig into making logic changes/doing ticket work.
What do you all think? Is this too much of a departure from the longer component file convention that you seem to have going on (at least in
FlowEditor
components)?