Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Team component folder structure #3492

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

jamdelion
Copy link
Contributor

@jamdelion jamdelion commented Aug 5, 2024

I've split this into a separate PR from the ticket work I'm doing so that this can easily be discarded if it's rocking the boat too much / destroying a convention in the codebase!

But...I've basically massively shortened the length of TeamMembers.tsx by splitting out the two components that were defined in there into MembersTable and TeamMembers, and also moving type definitions and styling declarations into their own files.

In my opinion, this makes the component files a lot cleaner, easier to read and easier to work with! I just hate scrolling past loads of styling to find out what a component does 😅 And I thought I'd kind of start with this before I dig into making logic changes/doing ticket work.

What do you all think? Is this too much of a departure from the longer component file convention that you seem to have going on (at least in FlowEditor components)?

@jamdelion jamdelion requested a review from a team August 5, 2024 14:51
Copy link

github-actions bot commented Aug 5, 2024

Removed vultr server and associated DNS entries

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense to pick up this change before adding more code and complexity here.

Certainly not wedded to keeping styles and component in a single file - it does get harder to manage as more is added.

@jamdelion jamdelion merged commit 6c02928 into main Aug 5, 2024
12 checks passed
@jamdelion jamdelion deleted the jh/refactor-team-members-code branch October 28, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants