fix: list of flows should display and be sorted by most recent operations, not flows.updated_at
#3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
commented
Jun 4, 2024
|
|
||
| export const formatLastPublishMessage = (date: string, user: string): string => | ||
| `Last published ${formatLastEditDate(date)} ago by ${user}`; |
There was a problem hiding this comment.
This is just a small tidy up so that all of the helper methods that rely on formatDistanceToNow() are co-located in the same file
|
Removed vultr server and associated DNS entries |
jessicamcinchak
commented
Jun 4, 2024
| b.operations[0]["createdAt"].localeCompare( | ||
| a.operations[0]["createdAt"], | ||
| ), | ||
| ); |
There was a problem hiding this comment.
Previously, we sorted directly via the GraphQL query like flows (order_by: { updated_at: desc }) {...} - but we want to sort via operations, not flows, so now we're doing a custom sort here !
There was a problem hiding this comment.
nit: possibly good use for ToSorted() to copy and sort array with one method
jessicamcinchak
changed the title
flows.updated_atflows.updated_at
RODO94
approved these changes
Jun 5, 2024
| b.operations[0]["createdAt"].localeCompare( | ||
| a.operations[0]["createdAt"], | ||
| ), | ||
| ); |
There was a problem hiding this comment.
nit: possibly good use for ToSorted() to copy and sort array with one method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
August mentioned that it's really disorienting that all the flows within a team now show the same "Edited 5 days ago" timestamp - this is because this message was referencing
flows.updated_atwhich changed whenflows.statusmerged and is updated, whereas we really think about "edits" to a flow coming from the associatedoperations.Now updated to display based on
operations, sharing the same formatting as in-graph view of "Last edited..." too. This means that both the list & graph timestamps will now match (previously they didn't 🙈), and that the list timestamps now ignore bulk flow migrations or non-data changes like renaming, toggling status, etc.See thread: https://opensystemslab.slack.com/archives/C5Q59R3HB/p1717571853477949
Testing:
Click into a flow, edit the graph data, click back out to the list of services within the team and confirm it's at the top of the list with a correct "Last edited {at} by {user}" message.
Note that real
operationsare not synced from production to other environments (staging, local, pizza), so you won't see a first and last name associated with the timestamp on the pizza until new edits are made. Only production has a full history!