Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set & track findProperty.action in analytics allow lists #3135

Merged
merged 2 commits into from
May 13, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented May 10, 2024

  • Adds column find_property_action to both analytics_summary & submission_services_summary views
    • Will be populated with one of two values: "Selected an existing address" or "Proposed a new address"
  • Will help us understand how users are proceeding through the service and evidence roadmap requests related to improving search capability & map interactions around proposing new addresses
    Screenshot from 2024-05-10 13-39-26

Copy link

github-actions bot commented May 10, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak requested a review from a team May 10, 2024 13:55
New = "Proposed a new address",
}

export const PASSPORT_COMPONENT_ACTION_KEY = "findProperty.action";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a new passport variable, rather than using _address.source has two main benefits to keep this quick & simple:

  • The values can be human readable in the source, rather than just "os" & "proposed"
  • We don't have to refactor allow list handling to work with deconstructed, nested passport variables like _address

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect - nice and simple 👍

@jessicamcinchak jessicamcinchak merged commit 6badad8 into main May 13, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/findproperty-allow-list-analytics branch May 13, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants