Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Styling for set component in graph #3066

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Apr 26, 2024

What does this PR do?

Adds subtle 'data' styling to the Set Component, inheriting font family (monospace) and background from editor data input.

Before:
image

After:
image

Example:
https://3066.planx.pizza/testing/set-value-append-replace

Copy link

github-actions bot commented Apr 26, 2024

Removed vultr server and associated DNS entries

@ianjon3s ianjon3s requested a review from a team April 30, 2024 09:56
@ianjon3s ianjon3s marked this pull request as ready for review April 30, 2024 09:56
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple & impactful !

@DafyddLlyr
Copy link
Contributor

Just a heads up that fairly shortly we'll need to think how we'll handle a few more options here (see https://github.com/theopensystemslab/planx-new/pull/2914/files#diff-7aaf25a63d4a989667eaec2c7c7e6e46589fb1e27f767f57deb3dcb927470746R143-R152)

Something to think about - I think this PR should progress in the meantime!

@ianjon3s
Copy link
Contributor Author

Just a heads up that fairly shortly we'll need to think how we'll handle a few more options here (see https://github.com/theopensystemslab/planx-new/pull/2914/files#diff-7aaf25a63d4a989667eaec2c7c7e6e46589fb1e27f767f57deb3dcb927470746R143-R152)

Something to think about - I think this PR should progress in the meantime!

Thanks @DafyddLlyr , interesting to see what's coming up

@ianjon3s ianjon3s merged commit 415cdff into main Apr 30, 2024
12 checks passed
@ianjon3s ianjon3s deleted the ian/set-component-styling branch April 30, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants