chore: Tidy up hardcoded MUI classnames #3000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
force-pushed
the
dp/tidy-up-mui-classnames
branch
from
d519f1c to
bb49f57
Compare
DafyddLlyr
commented
Apr 9, 2024
| @@ -58,7 +60,7 @@ const StyledAccordionSummary = styled(AccordionSummary)(({ theme }) => ({ | |||
| padding: "0", | |||
| margin: "0", | |||
| minHeight: "0", | |||
| "&.Mui-expanded": { | |||
| [`&.${accordionClasses.root}.Mui-expanded`]: { | |||
There was a problem hiding this comment.
Global classnames like Mui-expanded should not be used in isolation -
Never apply styles directly to state class names. This will impact all components with unclear side-effects. Always target a state class together with a component.
Docs: https://mui.com/material-ui/customization/how-to-customize/#overriding-styles-with-class-names
ianjon3s
approved these changes
Apr 9, 2024
|
Removed vultr server and associated DNS entries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tidy up / refactor I hit when working on #2993
MUI offers classnames as an import so we can avoid hardcoding these 👍