Skip to content

Commit

Permalink
chore: Remove hardcoded node version
Browse files Browse the repository at this point in the history
  • Loading branch information
DafyddLlyr committed Jan 3, 2025
1 parent 5c4bc22 commit c504a7b
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 24 deletions.
18 changes: 6 additions & 12 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ jobs:
version: ${{ vars.PNPM_VERSION }}
- uses: actions/setup-node@v4
with:
# node-version: ${{ vars.NODE_VERSION }}
node-version: 22.10.0
node-version: ${{ vars.NODE_VERSION }}
cache: "pnpm"
cache-dependency-path: "**/pnpm-lock.yaml"
- run: pnpm install --frozen-lockfile
Expand Down Expand Up @@ -128,8 +127,7 @@ jobs:
version: ${{ vars.PNPM_VERSION }}
- uses: actions/setup-node@v4
with:
# node-version: ${{ vars.NODE_VERSION }}
node-version: 22.10.0
node-version: ${{ vars.NODE_VERSION }}
cache: "pnpm"
cache-dependency-path: "**/pnpm-lock.yaml"
- name: Install dependencies
Expand Down Expand Up @@ -165,8 +163,7 @@ jobs:
version: ${{ vars.PNPM_VERSION }}
- uses: actions/setup-node@v4
with:
# node-version: ${{ vars.NODE_VERSION }}
node-version: 22.10.0
node-version: ${{ vars.NODE_VERSION }}
cache: "pnpm"
cache-dependency-path: "**/pnpm-lock.yaml"
- name: Setup .gitconfig
Expand Down Expand Up @@ -198,8 +195,7 @@ jobs:
- uses: actions/setup-node@v4
if: steps.cache-react-build-assets.outputs.cache-hit != 'true'
with:
# node-version: ${{ vars.NODE_VERSION }}
node-version: 22.10.0
node-version: ${{ vars.NODE_VERSION }}
cache: "pnpm"
cache-dependency-path: "**/pnpm-lock.yaml"
- name: Setup .gitconfig
Expand Down Expand Up @@ -256,8 +252,7 @@ jobs:
version: ${{ vars.PNPM_VERSION }}
- uses: actions/setup-node@v4
with:
# node-version: ${{ vars.NODE_VERSION }}
node-version: 22.10.0
node-version: ${{ vars.NODE_VERSION }}
cache: "pnpm"
cache-dependency-path: "**/pnpm-lock.yaml"
- run: pnpm install --frozen-lockfile
Expand Down Expand Up @@ -470,8 +465,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
# node-version: ${{ vars.NODE_VERSION }}
node-version: 22.10.0
node-version: ${{ vars.NODE_VERSION }}
cache: "pnpm"
cache-dependency-path: "**/pnpm-lock.yaml"
- name: Setup .gitconfig
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/push-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
# node-version: ${{ vars.NODE_VERSION }}
node-version: 22.10.0
node-version: ${{ vars.NODE_VERSION }}
# https://docs.github.com/en/free-pro-team@latest/actions/guides/caching-dependencies-to-speed-up-workflows#using-the-cache-action
- name: NPM cache
uses: actions/cache@v4
Expand Down Expand Up @@ -77,8 +76,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
# node-version: ${{ vars.NODE_VERSION }}
node-version: 22.10.0
node-version: ${{ vars.NODE_VERSION }}
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v4
with:
Expand Down
12 changes: 4 additions & 8 deletions .github/workflows/regression-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ jobs:
version: ${{ vars.PNPM_VERSION }}
- uses: actions/setup-node@v4
with:
# node-version: ${{ vars.NODE_VERSION }}
node-version: 22.10.0
node-version: ${{ vars.NODE_VERSION }}
cache: "pnpm"
cache-dependency-path: "**/pnpm-lock.yaml"
- run: pnpm install --frozen-lockfile
Expand Down Expand Up @@ -75,8 +74,7 @@ jobs:
version: ${{ vars.PNPM_VERSION }}
- uses: actions/setup-node@v4
with:
# node-version: ${{ vars.NODE_VERSION }}
node-version: 22.10.0
node-version: ${{ vars.NODE_VERSION }}
cache: "pnpm"
cache-dependency-path: "**/pnpm-lock.yaml"
- name: Setup .gitconfig
Expand Down Expand Up @@ -112,8 +110,7 @@ jobs:
version: ${{ vars.PNPM_VERSION }}
- uses: actions/setup-node@v4
with:
# node-version: ${{ vars.NODE_VERSION }}
node-version: 22.10.0
node-version: ${{ vars.NODE_VERSION }}
cache: "pnpm"
cache-dependency-path: "**/pnpm-lock.yaml"
- name: Setup .gitconfig
Expand Down Expand Up @@ -146,8 +143,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
# node-version: ${{ vars.NODE_VERSION }}
node-version: 22.10.0
node-version: ${{ vars.NODE_VERSION }}
cache: "pnpm"
cache-dependency-path: "**/pnpm-lock.yaml"
- name: Setup .gitconfig
Expand Down

0 comments on commit c504a7b

Please sign in to comment.