all component types correctly setting data fields

theopensystemslab · Jan 3, 2025 · b94e92a · b94e92a
1 parent c2d9133
commit b94e92a
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 9 deletions.
diff --git a/e2e/tests/ui-driven/src/create-flow.spec.ts b/e2e/tests/ui-driven/src/create-flow.spec.ts
@@ -233,7 +233,7 @@ test.describe("Flow creation, publish and preview", () => {
     await publishService(page);
   });
 
-  test("Can preview a published flow", async ({
+  test("Can preview a published flow with an external portal", async ({
     browser,
   }: {
     browser: Browser;
@@ -243,12 +243,17 @@ test.describe("Flow creation, publish and preview", () => {
       userId: context.user!.id!,
     });
 
-    await page.goto(`/${context.team.slug}/${serviceProps.slug}`);
+    await navigateToService(page, serviceProps.slug);
 
     await expect(
       page.getByRole("link", { name: "E2E/an-external-portal-service" }),
     ).toBeVisible();
 
+    const previewLink = page.getByRole("link", {
+      name: "Open published service",
+    });
+    await expect(previewLink).toBeVisible();
+
     await page.goto(
       `/${context.team.slug}/${serviceProps.slug}/published?analytics=false`,
     );
@@ -275,6 +280,7 @@ test.describe("Flow creation, publish and preview", () => {
     });
     await clickContinue({ page });
 
+    // The external portal question has been flattened into the overall flow data structure and can be successfully navigated through
     await answerQuestion({
       page,
       title: externalPortalFlowData.title,

diff --git a/e2e/tests/ui-driven/src/helpers/addComponent.ts b/e2e/tests/ui-driven/src/helpers/addComponent.ts
@@ -58,14 +58,16 @@ const createBaseComponent = async (
       await page.getByRole("combobox", { name: "Data field" }).click();
       await page
         .getByRole("combobox", { name: "Data field" })
-        .fill(options?.[0] || "");
+        .fill(options?.[0] || "proposal.address");
+      await page.getByRole("combobox", { name: "Data field" }).press("Enter");
       break;
     case ComponentType.ContactInput:
       await page.getByPlaceholder("Title").fill(title || "");
       await page.getByRole("combobox", { name: "Data field" }).click();
       await page
         .getByRole("combobox", { name: "Data field" })
-        .fill(options?.[0] || "");
+        .fill(options?.[0] || "proposal.contact");
+      await page.getByRole("combobox", { name: "Data field" }).press("Enter");
       break;
     case ComponentType.TaskList:
       await page.getByPlaceholder("Main Title").fill(title || "");
@@ -121,21 +123,24 @@ const createBaseComponent = async (
       await page.getByRole("combobox", { name: "Data field" }).click();
       await page
         .getByRole("combobox", { name: "Data field" })
-        .fill(options?.[0] || "");
+        .fill(options?.[0] || "otherDocument");
+      await page.getByRole("combobox", { name: "Data field" }).press("Enter");
       break;
     case ComponentType.FileUploadAndLabel:
       await page.getByPlaceholder("File type").fill(options?.[0] || "");
       await page.getByRole("combobox", { name: "Data field" }).click();
       await page
         .getByRole("combobox", { name: "Data field" })
-        .fill(options?.[1] || "");
+        .fill(options?.[1] || "otherDocument");
+      await page.getByRole("combobox", { name: "Data field" }).press("Enter");
       break;
     case ComponentType.List:
       await page.getByPlaceholder("Title").fill(title || "");
       await page.getByRole("combobox", { name: "Data field" }).click();
       await page
         .getByRole("combobox", { name: "Data field" })
-        .fill(options?.[0] || "");
+        .fill(options?.[0] || "proposal.list");
+      await page.getByRole("combobox", { name: "Data field" }).press("Enter");
       break;
     case ComponentType.Content:
       await page

diff --git a/e2e/tests/ui-driven/src/helpers/userActions.ts b/e2e/tests/ui-driven/src/helpers/userActions.ts
@@ -328,14 +328,14 @@ export async function answerListInput(
   await page
     .getByRole("combobox", { name: "What best describes this unit?" })
     .click();
-  await page.getByRole("option", { name: unitType }).click();
+  await page.getByRole("option", { name: unitType, exact: true }).click();
 
   await page
     .getByRole("combobox", {
       name: "What best describes the tenure of this unit?",
     })
     .click();
-  await page.getByRole("option", { name: tenure }).click();
+  await page.getByRole("option", { name: tenure, exact: true }).click();
 
   await page
     .getByLabel("How many bedrooms does this unit have?")