feat: dispatch events for area and geojson changes beyond drawMode #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for oslmap ready! 🔨 Explore the source changes: 5b4ad27 🔍 Inspect the deploy log: https://app.netlify.com/sites/oslmap/deploys/61717b4ac7fcc700070aad30 😎 Browse the preview: https://deploy-preview-69--oslmap.netlify.app/ |
gunar
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces console.logs with
this.dispatch()(which you'll still see in your console when debugging is enabled).See index.html comments for which event names are applicable to which data "modes" (drawing, showing/clicking features, loading static data etc).
This helps us prototype a click-to-select interaction in PlanX's DrawBoundary and have feature parity with current drawMode - for example, by showing the area below the map and setting
property.boundary.sitepassport variables as the geojson representation of merged OS Features.Closes #23