fix: drawGeojsonData should accept "Feature" and "FeatureCollection" data since introducing drawMany
#491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
RODO94
approved these changes
Sep 2, 2024
| const geojsonSource = new VectorSource(); | ||
|
|
||
| if (this.geojsonData.type === "FeatureCollection") { | ||
| let features = new GeoJSON().readFeatures(this.geojsonData, { | ||
| featureProjection: "EPSG:3857", | ||
| }); | ||
| geojsonSource.addFeatures(features); | ||
| geojsonSource.setAttributions(this.geojsonDataCopyright); | ||
| } else if (this.geojsonData.type === "Feature") { | ||
| let feature = new GeoJSON().readFeature(this.geojsonData, { | ||
| featureProjection: "EPSG:3857", | ||
| }); | ||
| geojsonSource.addFeature(feature); |
There was a problem hiding this comment.
Took me a second to realise the differences between these parts. Is the need for two different functions relate to one accessing the Features array of a FeatureCollection and the other just taking the Feature as an object, or is there another reason for having two different functions / if clauses?
There was a problem hiding this comment.
Yes exactly OpenLayers provides different methods depending if GeoJSON is single Feature or a FeatureCollection, and we want to keep our public-facing prop flexible to accepting eithe, therefore we do this conditional check !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to make drawing data "go back-able" in Planx when
drawManyis true.This was missed when introducing
drawManyprop -drawGeojsonDatawas only accepting/processing a single"Feature"and would fail if the passed in prop was a GeoJSON"FeatureCollection"- now account for either, same asgeojsonData