Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dispatch geojsonChange events in two projections #255

Merged

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Jan 19, 2023

When drawing or selecting features, dispatch their associated geojson change events in two projections: EPSG:3857 (web mercator) & EPSG:27700 (BNG). Previously, we defaulted to only EPSG:3857.

In PlanX, this will enable us to easily get both the Easting (X), Northing (Y) & longitude, latitude coordinates of a point or polygon without needing to install any extra dependencies to handle further conversions later.

Will flag as a break in our next release, as it changes the data format output by the event!

@netlify
Copy link

netlify bot commented Jan 19, 2023

Deploy Preview for oslmap ready!

Name Link
🔨 Latest commit 639de71
🔍 Latest deploy log https://app.netlify.com/sites/oslmap/deploys/63c990e4999fba00096fab90
😎 Deploy Preview https://deploy-preview-255--oslmap.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jessicamcinchak
Copy link
Member Author

@jessicamcinchak jessicamcinchak requested a review from a team January 19, 2023 13:23
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect ✅

image

As it's certainly a breaking change we'll need to jump to v0.7 as you said.

Something to discuss (maybe at retro?) - is it time for v1? What would that look like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants