feat: show features without border & ability to add a custom marker #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
gunar
approved these changes
Jul 5, 2022
| @@ -85,9 +87,24 @@ export class MyMap extends LitElement { | |||
| @property({ type: Boolean }) | |||
| featureFill = false; | |||
|
|
|||
| @property({ type: Boolean }) | |||
| featureBorderNone = false; | |||
There was a problem hiding this comment.
Nit: I tend to favor positive naming schemes (e.g. featureBorder = true) as to avoid double negation (e.g. featureBorderNone = false).
There was a problem hiding this comment.
See #37 - had originally defaulted to positive naming schemes for boolean properties, but then learned overtime that it doesn't play so nice with Lit so now consistently declaring all boolean props false by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two styling features to help clarify how we highlight addresses:
boolean property
featureBorderNoneto control whether or not to show a border when highlighting an OS Feature that intersects with a point<my-map zoom="20" showFeaturesAtPoint featureFill="#fff" featureBorderNone />boolean property
showMarkerto show a marker on the map (defaults to center latitude & longitude), with optional number propertiesmarkerLatitude,markerLongitudeto specify a custom latitude & longitude to place the marker at. The marker will default to a black dot, but you can pass a custom hex code or CSS color name tomarkerColor.<my-map zoom="20" showMarker />