Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: csv upload should not save file #322

Merged
merged 2 commits into from
Dec 15, 2024
Merged

fix: csv upload should not save file #322

merged 2 commits into from
Dec 15, 2024

Conversation

golanglemonade
Copy link
Member

  • fixes csv upload, the files were being saved to the files schema and then unable to be read for input. These files should instead be skipped by the middleware
  • fixes labeler that apparently did not save on my last PR

Confirmed opencloud-cloud works correctly again to seed data:

task cli:init                                          
task: [cli:init] go run cmd/cli/main.go seed init
> registering users...  10% [>              ]  [0s:0s]{"level":"info","app":"openlane-cloud","file":{},"time":"2024-12-14T20:29:02-07:00","message":"loaded CSV file"}
> creating organizations...  20% [==>            ]  [1s:4s]{"level":"info","app":"openlane-cloud","file":"demodata/orgs.csv","time":"2024-12-14T20:29:03-07:00","message":"loading organizations"}
{"level":"info","app":"openlane-cloud","file":{},"time":"2024-12-14T20:29:03-07:00","message":"loaded CSV file"}
> creating groups...  60% [========>      ]  [3s:2s]{"level":"info","app":"openlane-cloud","file":{},"time":"2024-12-14T20:29:05-07:00","message":"loaded CSV file"}
> creating invites...  70% [=========>     ]  [3s:2s]{"level":"info","app":"openlane-cloud","file":{},"time":"2024-12-14T20:29:06-07:00","message":"loaded CSV file"}
> creating subscribers...  80% [===========>   ]  [3s:1s]{"level":"info","app":"openlane-cloud","file":{},"time":"2024-12-14T20:29:06-07:00","message":"loaded CSV file"}

Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
@golanglemonade golanglemonade requested a review from a team as a code owner December 15, 2024 03:52
@github-actions github-actions bot added bug Something isn't working graphapi ci labels Dec 15, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 20%)

See analysis details on SonarQube Cloud

@golanglemonade golanglemonade enabled auto-merge (squash) December 15, 2024 04:00
@golanglemonade golanglemonade merged commit 3933683 into main Dec 15, 2024
16 of 17 checks passed
@golanglemonade golanglemonade deleted the bug-csv-upload branch December 15, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci graphapi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants