Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: control objectives and their permissions, group permissions mixin #250

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

golanglemonade
Copy link
Member

@golanglemonade golanglemonade commented Nov 26, 2024

  • Adds a new GroupPermissionsMixin that will add the group edges + hooks when added to a schema for viewer, editor, and blocked groups permissions
  • Adds the control objective cli command
  • Updates the fga model for control objective, sub controls, and controls to align with the risk permissions
  • Updates the controlobjective schema to include the object owned mixin based on their parent program, and the new group permissions mixin for group based permissions
  • Cleans up all existing schemas with group permissions to use the new mixin instead of adding manually to each schema
  • Adds a WithOrganizationOwner to the object owned mixin to add the org owned field, edges, and hook to object owned schemas - this allows the fields to be added, without the parent inherited permissions
  • Removes the duplicated FilterQuery interceptor from a few schemas (this is already the default interceptor for object owned schemas)
  • Adds CRUD tests for control objectives

Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
@golanglemonade golanglemonade marked this pull request as ready for review November 26, 2024 20:54
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
12.3% Coverage on New Code (required ≥ 20%)
13.6% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@golanglemonade golanglemonade merged commit 38d376b into main Nov 26, 2024
14 of 15 checks passed
@golanglemonade golanglemonade deleted the feat-control-objective branch November 26, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants