fix: Ensure the database is not populated several times in PHP 8.2 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PHP 8.2 static properties in traits were no longer supported. Due to this issue the database was populated every time at the beginning of a new test class in the refresh trait. Now we are using a defined var to store if the db is already populated.
|
Thank you @TravisMarkvh! Sorry for the delay. |
wuchen90
added a commit
to wuchen90/AliceBundle
that referenced
this pull request
Sep 21, 2023
After this PR theofidry#43, the `self::$fixtures` isn't populated anymore for the tests that are located in other classes. Since the population code is executed only once and stores the fixtures into the first test class static `$fixtures` variable, the other class will get `self::$fixtures === null`.
wuchen90
added a commit
to wuchen90/AliceBundle
that referenced
this pull request
Sep 21, 2023
After this PR theofidry#43, the `self::$fixtures` isn't populated anymore for the tests that are located in other classes. Since the population code is executed only once and stores the fixtures into the first test class static `$fixtures` variable, the other class will get `self::$fixtures === null`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP 8.2 static properties declared in traits behaves as if they were declared in the class using the trait, hence it will no longer be shared between classes using this trait.
Closes #42.
This PR is another take of #42 where the state is kept within an internal constant instead as a constant would mean introducing global state that cannot be mutated which I am not too found of.