Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chance of multiple popups appearing when scan key is pressed multiple times without moving #997

Merged
merged 1 commit into from
May 27, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented May 25, 2024

This can occur if the scan button is pressed multiple times without moving the mouse after the popup appears and the popup contains a saved mouse position from a previous popup that matches the position of scannable text in the current popup.

This change clears the mouse position when the popup is closed so there will never be any saved mouse position when the popup is opened.

Minimal reproduction steps for this issue:

  1. Scan a word
  2. Mouse over scannable text within the popup
  3. Close the popup without moving the mouse (press esc) while the cursor is still above the scannable text in the popup
  4. Mouse over word scanned in step 1 and do not move the mouse after this
  5. Press the scan button to scan the word
  6. Press the scan button again

You will now have a second popup even though the mouse is not over the text that was just scanned inside the first popup.

@Kuuuube Kuuuube added kind/bug The issue or PR is regarding a bug area/ui-ux The issue or PR is related to UI/UX/Design labels May 25, 2024
@Kuuuube Kuuuube requested a review from a team as a code owner May 25, 2024 18:07
@Kuuuube Kuuuube changed the title Fix double popup issue Fix chance of multiple popups appearing when scan key is pressed multiple times without moving May 25, 2024
@jamesmaa jamesmaa added this pull request to the merge queue May 27, 2024
Merged via the queue into themoeway:master with commit e1c3613 May 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants