Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove playwright's success PR comments #906

Merged
merged 1 commit into from
May 10, 2024

Conversation

dlsf
Copy link

@dlsf dlsf commented May 10, 2024

Closes #900. As far as I can tell, this edit to the GitHub Actions pipeline should be sufficient, and the change works on my fork :)

Signed-off-by: Daniel Scherf <35780068+dlsf@users.noreply.github.com>
@dlsf dlsf requested a review from a team as a code owner May 10, 2024 21:48
Copy link

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@dlsf
Copy link
Author

dlsf commented May 10, 2024

GitHub Actions is still using the old config for this PR, hence why the message is showing up, but it will not appear in future PRs once this one is merged

@jamesmaa jamesmaa added this pull request to the merge queue May 10, 2024
Merged via the queue into themoeway:master with commit fdfbfc2 May 10, 2024
10 checks passed
@dlsf dlsf deleted the ci/playwright-success-silencing branch May 10, 2024 23:06
@Kuuuube Kuuuube added the kind/meta The issue or PR is meta label May 11, 2024
@Casheeew Casheeew added the area/ci The issue or PR is related to continuous integration and/or continuous delivery label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci The issue or PR is related to continuous integration and/or continuous delivery kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silence playwright message on success.
4 participants