Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anki template field marker menu #725

Conversation

toasted-nutbread
Copy link

Fixes #721. I searched for other places in the code that might have this issue, didn't see anything else.

@toasted-nutbread toasted-nutbread requested a review from a team as a code owner February 24, 2024 03:44
Copy link

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

Copy link
Collaborator

@djahandarie djahandarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. BTW would have it been possible to catch this regression via a Playwright screenshot of something?

@djahandarie djahandarie added this pull request to the merge queue Feb 25, 2024
Merged via the queue into themoeway:master with commit 0e005f2 Feb 25, 2024
10 checks passed
@toasted-nutbread
Copy link
Author

Probably, although I haven't done much with the playwright stuff at this point.

@djahandarie
Copy link
Collaborator

Maybe opening every popup possible on the settings page and taking a screenshot of it would work? Not sure if that would have caught this or not but it'd be better than nothing I guess

@djahandarie djahandarie added the kind/bug The issue or PR is regarding a bug label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some dropdown menus do not function
2 participants