Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add documentation for {phonetic-transcriptions} #685

Merged
merged 1 commit into from
Feb 15, 2024
Merged

add documentation for {phonetic-transcriptions} #685

merged 1 commit into from
Feb 15, 2024

Conversation

StefanVukovic99
Copy link
Member

Closes #623

@StefanVukovic99 StefanVukovic99 requested a review from a team as a code owner February 13, 2024 13:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

⚠️ Visual differences introduced by this PR; please validate if they are desirable.

View Playwright Report (note: open the "playwright-report" artifact)

djahandarie
djahandarie approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@djahandarie djahandarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cool if we could somehow lint missing documentation. Or even better, auto-generate this documentation based on the contents of something in the jsdoc.

@djahandarie djahandarie added this pull request to the merge queue Feb 15, 2024
Merged via the queue into themoeway:master with commit 9432e4b Feb 15, 2024
7 of 8 checks passed
@toasted-nutbread toasted-nutbread mentioned this pull request Feb 15, 2024
Open
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djahandarie djahandarie djahandarie approved these changes

@toasted-nutbread toasted-nutbread toasted-nutbread approved these changes

Assignees
No one assigned
Labels
kind/meta The issue or PR is meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pitch-accent-categories and phonetic-transcriptions handlebars lack documentation
3 participants
@StefanVukovic99 @djahandarie @toasted-nutbread