Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change inflection info style #561

Closed
wants to merge 2 commits into from

Conversation

seth-js
Copy link

@seth-js seth-js commented Jan 22, 2024

Simplifies inflection info layout.

The inflection info is taking a bit too much space, especially for non-Japanese languages that can have a lot of possible inflections. The dictionary and algorithm emojis are also a bit distracting, and I don't think that users really need to know where their inflection info comes from.

japanese-two-inflections
spanish-two-inflections
spanish-one-inflection

Longer inflection info still gets moved below the headword:

spanish-long-inflection

Simplifies inflection info layout.
@seth-js seth-js requested a review from a team as a code owner January 22, 2024 22:49
@toasted-nutbread
Copy link

This seems to be a personal preference thing, and as such I'll post some of my own subjective thoughts:

  1. I believe you can achieve this with custom CSS.
  2. I think the multiline text next to the single large headword is cluttered and the meaning is unclear when multiple lines are present.
  3. I think this layout will not look great in situations where there are headword tags or multiple headwords.

@StefanVukovic99
Copy link
Member

The idea here is that a user might have multiple dictionaries with deinflections + a deinflector for the language, and may want to disable some of them, so knowing which inflection is coming from where is useful. If this is kept, we might even want to show which dictionary is the source on the inflection. We've also discussed having a source for each individual rule. If this is to be removed, then source is unused, and may want to remove the rest of references to it.

Changing the default css to inline-block is good I think. Overall, I'd rather keep the feature, and leave appearance to default/custom css. It's been only 2 days since #503 so it's hard to gauge how (un)popular this is.

@seth-js
Copy link
Author

seth-js commented Jan 22, 2024

@StefanVukovic99
I guess I'm acting too quickly. We'll have to wait and see what users think. I'll keep the custom CSS for my dictionary. Another option could be adding a Compact inflections option under Compact tags which can then add the inline-block and hide icons if needed.

@seth-js seth-js closed this Jan 22, 2024
@seth-js seth-js deleted the inflection-style-change branch January 22, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants