improve dictionary validation #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
djahandarie
previously approved these changes
Jan 20, 2024
djahandarie
approved these changes
Jan 20, 2024
|
@Scrub1492 @stephenmk I noticed that the latest version of Jitendex https://github.com/stephenmk/Jitendex/releases/tag/v4.1-1 is now failing to validate. Do we know why?
|
|
I can't reproduce that error. I just built the extension locally using the code from commit 39265a4 and installed it in firefox and chromium. Neither one had a problem verifying and importing the jitendex zip file from that release page. |
|
You're right, sorry for the false alarm -- I had an old schema locally and had to ./build.sh again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #507 (dev dictionary validation now validates files with skipped indexes).
Also changed the
QueryDetailsin dictionary-import.js_getArchiveFilesto be a simple 2d array as opposed to a Map because it is more performant when looped over.