add phonetic transcriptions term meta type

[StefanVukovic99]

part 2 of #422. Adds a 3rd term meta type for IPA transcriptions.

The types could maybe be improved somehow, there is a ts error in anki-note-data-creator.js because of the union type.

Also, I missed 2 references to dictionary-data-util.js in #429, should i fix that in this pr or make another?

[github-actions]

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

[toasted-nutbread]

Also, I missed 2 references to dictionary-data-util.js in #429, should i fix that in this pr or make another?

Are you referring to the JSON config files? It's fine to be in this since it's close enough related I'd say.

[toasted-nutbread]

Left some initial thoughts.

[toasted-nutbread]

Assuming you're based off latest master, you can run npm run test-code-write to fix the test data.

[StefanVukovic99]

Assuming you're based off latest master, you can run npm run test-code-write to fix the test data.

npm run test-code-write

> yomitan@0.0.0 test-code-write
> vitest run --config test/data/vitest.write.config.json


 RUN  v0.34.6 /media/stefan/DATA/EDesktop/Projekti/Coding/yezichak

 ❯ test/dictionary-data.write.js (0)

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Suites 1 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL  test/dictionary-data.write.js [ test/dictionary-data.write.js ]
ReferenceError: TransformStream is not defined
 ❯ node_modules/@zip.js/zip.js/lib/core/constants.js:238:19
 ❯ ext/js/dictionary/dictionary-importer.js:2:31
      1| /*
      2|  * Copyright (C) 2023  Yomitan Authors
       |                               ^
      3|  * Copyright (C) 2020-2022  Yomichan Authors
      4|  *

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

 Test Files  1 failed (1)
      Tests  no tests
   Start at  22:57:17
   Duration  2.15s (transform 626ms, setup 0ms, collect 0ms, tests 0ms, environment 0ms, prepare 211ms)

[toasted-nutbread]

Try rebuilding libraries: npm run build-libs

[StefanVukovic99]

Try rebuilding libraries: npm run build-libs

No change.

[StefanVukovic99]

Try rebuilding libraries: npm run build-libs

No change.

updated Node to v20, manually deleted node_modules, npm install - now it works

[toasted-nutbread]

🤔

Edit - nevermind, you commented above.

~\yomitan>npm ci
npm WARN deprecated @types/handlebars@4.1.0: This is a stub types definition. handlebars provides its own type definitions, so you do not need this installed.      
npm WARN deprecated source-map-resolve@0.6.0: See https://github.com/lydell/source-map-resolve#deprecated

added 492 packages, and audited 493 packages in 8s

108 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

~\yomitan>npm run build-libs

> yomitan@0.0.0 build-libs
> node ./dev/bin/build-libs.js


~\yomitan>npm run test-code-write

> yomitan@0.0.0 test-code-write
> vitest run --config test/data/vitest.write.config.json


 RUN  v0.34.6 ~/yomitan

 ✓ test/dictionary-data.write.js (1) 1386ms
   ✓ Write dictionary data expected data 1385ms

 Test Files  1 passed (1)
      Tests  1 passed (1)
   Start at  17:10:41
   Duration  4.80s (transform 543ms, setup 0ms, collect 830ms, tests 1.39s, environment 0ms, prepare 96ms)


~\yomitan>git diff --shortstat
 3 files changed, 893 insertions(+), 31 deletions(-)

[toasted-nutbread]

I think overall this looks good. The only thing that I think would be good to add is a/some test data in test/data/translator-test-inputs.json and test/data/dictionaries/valid-dictionary1/term_meta_bank_1.json.

[StefanVukovic99]

I've added some test data.

[djahandarie]

Thanks so much both of you for polishing this PR 🙏🙏