-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix add profile conditions #416
Conversation
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
Presumably this is due to elements not existing in certain contexts. If that's the case, mark the type as nullable and omit the cast.
|
That being said, this is probably another case of legacy code never being fully removed. If you search for |
For The reason these dead codepaths and unnecessary checks exist is because there was a massive UI overhaul of the settings page a long time ago, and the same classes would drive both versions of the settings page for the time they co-existed. |
Thanks. I included the changes. |
This change resolves #414 .
I believe this bug is caused by #364 . However, I am not sure if this solution captures every instance caused by this change.
@toasted-nutbread thoughts?