Minor performance optimizations for dictionary import #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
djahandarie
approved these changes
Dec 21, 2023
toasted-nutbread
approved these changes
Dec 21, 2023
I did try to compare performance but its not very reliable. Also this doesn't deal directly with the importing step to IndexedDB, so there will probably only be a minor improvement. |
djahandarie
added
the
kind/enhancement
djahandarie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplements _getArchiveFiles so that its only run once.
This change allows you to break early if you found the match, avoiding having to cycle through the entire fileMap for each file type.
For a dictionary with mostly files of
term_bank_?.jsonformat (most dictionaries), the time is improved to O(n) instead of O(n*m).