forked from FooSoft/yomichan
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor touch scan behavior #1442
Open
khaitruong922
wants to merge
12
commits into
themoeway:master
Choose a base branch
from
khaitruong922:touch-scan-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor touch scan behavior #1442
khaitruong922
wants to merge
12
commits into
themoeway:master
from
khaitruong922:touch-scan-refactor
+44
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaitruong922
commented
Sep 24, 2024
View Playwright Report (note: open the "playwright-report" artifact) |
There are probably some cases where the user wants to Yomitan as they are typing. Will scan input field if the tap does not change caret position. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1433
Changes:
scanAltText
option, default to not scan alt text on touch event.I don't know if there is any use case of scanning alt text, hyperlink or input on mobile or touch screen. If this is not intended behavior then we can disable them on touch event.
Making this behavior a setting such as
scanInteractiveElements
is not a really good idea because touch-screen laptops exist and users need to take extra step in settings to disable/enable them.