Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste on search page will trigger search #1348

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

khaitruong922
Copy link

@khaitruong922 khaitruong922 commented Aug 25, 2024

Fixes #1346

Paste on everywhere (except on input field) will update the search input and trigger search.
Should this be default behavior or we need to make it as an option?

@khaitruong922 khaitruong922 requested a review from a team as a code owner August 25, 2024 09:32
Copy link

⚠️ Visual differences introduced by this PR; please validate if they are desirable.

View Playwright Report (note: open the "playwright-report" artifact)

@MarvNC
Copy link
Member

MarvNC commented Aug 25, 2024

Thanks for doing this. I don't think it needs an option since hitting ctrl v is pretty intentional.

Copy link
Collaborator

@jamesmaa jamesmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jamesmaa jamesmaa added this pull request to the merge queue Aug 25, 2024
Merged via the queue into themoeway:master with commit f7a6eb8 Aug 25, 2024
11 checks passed
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl V to Search on Search Page
4 participants