forked from FooSoft/yomichan
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ko] Fix -ida transforms #1288
Merged
Merged
[ko] Fix -ida transforms #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Casheeew
commented
Jul 30, 2024
•
edited
Loading
edited
- Fixes some issues with -ida transforms such as 이어야 or 이어야만 not deinflecting to postpositional particle 이다
- fix typo
- fix 이는 incorrectly deinflecting to postpositional particle 이다, should be 인
- add 예요 deinflection
jamesmaa
previously approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want a rubber stamp
@Lyroxide :nanabeg: |
Casheeew
added
kind/bug
The issue or PR is regarding a bug
area/linguistics
The issue or PR is related to linguistics
labels
Jul 30, 2024
Looks good |
Kuuuube
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for lyroxide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/linguistics
The issue or PR is related to linguistics
kind/bug
The issue or PR is regarding a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.